committed with some modifications and omissions. details inline and below...
On Friday, May 3, 2002, at 12:59 AM, Sam Joseph wrote: > 4. Makes SqlEnum a public class so that people can pass different > comparators into Peer objects. Specifically omitted this one. As John explained the constants in Criteria are preferred to prevent confusion. If you provide a test which demonstrates where the constants in Criteria are insufficient, then we can fix Criteria. But making SqlEnum public can only make Criteria more confusing. > Oh yes, and my criterion string parsing classes that are used by the > CriteriaTest are now in a separate file CriterionParser.java - included > for your amusement. Still omitting this CriterionParser and the corresponding tests. I'm sorry to keep postponing that but I want to take more time than I have to look it over. Couple other comments about coding style. I've been taking extra time to massage your patches. Please take a close look at how I've been wrapping some long lines in the patches you've sent. And please don't prefix your variables with x_ or whatever. Fine for you to have those in your own code, but we want clean looking variables in Turbine code. 8^) That, by the way, is one of the things holding me up on the CriteriaParser code. And four space indents, please. In spite of these comments, please know that your patches are very appreciated. Thanks for contributing! -Eric -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
