I applied your patch but I was expecting that you were going to submit a
patch for methods such as
getManager() that go along with getManagerId(). So that there would be
a getManager(Connection).
If you submit a patch for these methods as well, please make sure your
diff is the correct polarity. Your patch showed the code as being
removed.
john mcnally
On Wed, 2002-06-05 at 11:50, Subhash wrote:
> John,
> I am attaching the patch to Object.vm to make this change.
>
> I have taken the approach of least code change to the template, the best
> approach would have been to abstract have one implementation for the referenced
> objects, but in this case, what I have done is just copy the methods
>
> get${relCol}() and get${relCol}(Criteria c) to taken a Connection object,
> and following the same paradigm, the get${relCol}(Criteria c,Connection con)
> does the work.
>
> Please let me know if I need to make any other changes.
>
> Thanks, -Subhash.
>
>
> --- John McNally <[EMAIL PROTECTED]> wrote:
> > diff -u and make sure it isn't linewrapped or send it as an attachment.
> >
> > On Tue, 2002-06-04 at 17:07, Subhash wrote:
> > >
> > > will start working on submitting the patch.
> > >
> > > if there a process for submitting patches or just send the diff output to
> > this
> > > group?.
> > >
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! - Official partner of 2002 FIFA World Cup
> http://fifaworldcup.yahoo.com
> ----
>
> --
> To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
