Stephen Haberman wrote: > Hello, > > I had proposed two refactorings of the build-torque.xml that received > good reception: moving all of the taskdefs out of the targets to avoid > duplication declarations and make targets easier to read and also > removing the project- prefix from most of the targets. > > I added targets with the old names that just make a call to the new > targets to act as deprecated place holders. I just now realized that I > didn't put in an echo about the project- targets being deprecated...I > can do that after the patch is supplied or re-submit another one with > the messages in it if it's decided a message is okay. > > Also, instead taskdefs all of the tasks to the name of the target their > in, I used the class name of the task, e.g.: > > <taskdef > name="torque-data-model" > classpathref="torque-classpath" > classname="org.apache.torque.task.TorqueDataModelTask"/> > > Instead of the TorqueDataModelTask taking on various identities > (torque-om, ojb-model, etc.) depending on which target it was in. > > I percolated the taskdef renaming throughout the build-torque.xml so > everything should work fine (the test & test-classpath targets run > fine). > > Also, I just realized, if this patch gets accepted, I'll go ahead and > update the test suites to remove the project- prefix and also the > documentation and submit patches for those. > > - Stephen
the patch looks good! please add the deprecation messages and send another patch it would be fantastic if you also send patches for the tests and docs ;-) martin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
