I will of course try to make my patch "right" as possible - it will at some point end up in production code for which my reputation and job will depend. However, I have a few comments:
1 - My changes will (do) depend on some of the changes/corrections I have already submitted, which are very slow to be integrated (most notably my ComboKey fix, submitted with test case). Currently to commit my pk change, I would have to submit a large (around 1000 line) patch that includes this and other small changes. 2 - I have a few other small patches that stand alone, but support this larger change. I would like to submit those seperately, then submit the pk change. This would require some help in getting these applied in a relatively quick manner. 3 - While making my change, I am coming across numerous places where I would like to suggest other changes, in fact, the new way of doing things in some cases (imho) higlight things that require a re-think - they never became issues before, but could now. I would prefer to not hold this change untill each and every one of those issues is discussed and resolved - this change/patch would become out of hand at that point, and I would not be able to eficiently maintain my seperate version untill accepted, thus causing me to abandon the fix. 4 - Hard as I may try to make sure that I cover all situations, I cannot, and there will most assuredly be flaws or bugs introduced by my changes - be it new bugs, or old bugs that hid well.. I would preferr to get my change into the tree and have everyone help test and debug, rather than keep it seperate for a long period of time trying to find bugs that my particular use will never raise. I will of course bring to the list my discussions and insights into places where I think more work/thought may be needed, but I do not want to hold up this change for each of those discussions - it seems that the bulk of the opinion is that this is a good idea (in fact noone spoke out against it), and as such deserves the attention of the entire community to complete. "Release early, release often". I will commit to providing my time to complete/bugfix/tweak this change - I know this is a promise from someone you do not know, but I will stand by it. And an update on the change - I have it complete in my sources, somewhat tested (using it in our applictation!). It will surely need some tweaking once the community gets to look it over and experiment with it. I will begin submitting patches for the stand alone changes, waiting for a response to this message by the Torque maintainers before the "big one". Thank you for your time Russell > -----Original Message----- > From: John McNally [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, September 18, 2002 3:54 PM > To: J. Russell Smyth > Cc: [EMAIL PROTECTED] > Subject: [TORQUE] Issue #TRQ41 modified > > > > Issue 'TRQ41' has just been modified by user 'jmcnally' > > You can view the issue detail at the following URL: > <http://scarab.werken.com/issues/id/TRQ41> > > The following modifications were made to this issue: > > I am okay with this change assuming the patch is done right > (I have confidence it will be). If someone wants to commit > this other than myself, please make an attempt to coordinate > with me before doing so. thanks. john mcnally > > > > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
