On Sun, 2002-02-24 at 19:34, Erik Hatcher wrote:
> I have a recommendation for the Torque Ant tasks.  For attributes that are
> for file or directory names, change the parameter type from String to File.
> 
> For example...
> 
> TorqueSQLTask:
>     public void setIdTableXMLFile(String idXmlFile)
> 
> I tried running this task from a different directory than the build file
> itself (master build using <ant> to call a sub-project build).  It failed
> because it was looking for a directory relative to my current working
> directory rather than relative to Ant's ${basedir}.  Using File would have
> taken care of this.
> 
> Is that reasonable?  Any reason not to make this change?  I'd submit a
> patch, but I wanted to run it by the list first.

A patch and verification that the testbed passes and that sounds good to
me. 

> 
>     Erik
> 
> p.s. I'm not on the -dev list (I get *way* too much e-mail as it is!) - but
> the dev folks are here too it seems.
> 
> 
> --
> To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
-- 
jvz.

Jason van Zyl
[EMAIL PROTECTED]

http://tambora.zenplex.org


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to