Rodney Schneider wrote:
Would it be possible for you to either supply a patch or at least log an issue in Scarab for this problem?
I can certainly file bug reports. Posting patches will need me to get motivated ;-) I had to get setup so I could hook a debugger into Turbine to get Intake figured out (that shows how much room for improvement there is!) so tracking down poor error reporting should be relatively easy. I'll try and put some patches together.
I have always used (note the capitals). This should be mentioned in the Intake Howto.
A note in the howto would be a good interim measure. Not munging the names the user specifies would be better :-)
The exception and error handling in Turbine leaves much to be desired.
Nearly everything 'throws Exception'. I don't think the Turbine
developers had much experience with exception handling when they wrote
Yeah, that would be symtomatic. Exception handling takes a little getting used to.
the code. Torque has recently been changed to throw TorqueException.
The parts of Turbine that currently throw Exception should either throw
TurbineException or a subclass of it. I have attached a patch to
Agree 100%.
TurbineException for you to retrieve its nested exception so you can log a decent error message.
You might want to look at using commons-lang's ChainedException (I think that's right) rather the re-inventing it ;-) My prefered style is generally to define a ChainedExceptionInterface and ChainedExceptionHelper; that lets me extend existing exception classes where appropriate, and include chaining functionality on every exception :)
Now that Turbine 2.2 has been released, expect the Turbine 2.x codebase to be majorly overhauled and cleaned up. You are more than welcome to help with this effort :)
<grin> no doubt! I'm sort of waiting on seeing whether Turbine has a viable future at the moment after reading so many 'Turbine 3 was a failed experiment' / 'the core committers have moved on to other things' / 'Plexus/Sumit it the One True Way Forward' threads on this list over the last two or three months. I'm not endorsing any of those sentiments, only worrying about whether they're valid ;-) I saw Hennings recent post that was somewhat in the other direction, which is encouraging, but I would like to see more positive affirmation of Turbine's future. I'll join the dev list and see what the climate's like.
Eventually the services will be decoupled from Turbine, but how this is going to be done has not yet been decided. Torque has already been completely decoupled.
I think I'd be more interested in helping this happen than fixing up what's there now. That means a bit more learning curve but it would be taking things forward rather than sideways ;-)
L.
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
