Hakan Tandogan wrote:
>
> Hi,
>
> The code in Turbine assumes that Column names in Databases are
> always in uppercase. This is not always true, at least not for Postgres. The
> following patch forces uppercase names in village:
This isn't a good fix. The actuality of the Turbine code is that it
assumes that all code in Turbine uses tables that were set up with the
included database install scripts. In these scripts uppercase names are
used, because that is always going to work (lowercase and mixed case get
converted on some databases).
-1 on changing Village. I think the install scripts determine the case,
not the code. This code (in Village) will fail on databases like mySQL
that do not force uppercase.
-Brett
>
> Regards,
> Hakan
>
> Index: com/workingdogs/village/Column.java
> ===================================================================
> RCS file: /products/cvs/external/village/com/workingdogs/village/Column.java,v
> retrieving revision 1.3
> diff -u -u -r1.3 Column.java
> --- com/workingdogs/village/Column.java 1999/11/29 23:15:18 1.3
> +++ com/workingdogs/village/Column.java 2000/01/05 15:04:31
> @@ -113,7 +113,7 @@
> void populate (ResultSetMetaData rsmd, int colNum) throws SQLException
> {
> this.columnNumber = colNum;
> - this.name = rsmd.getColumnName (columnNumber);
> + this.name = rsmd.getColumnName(columnNumber).toUpperCase();
> this.tableName = rsmd.getTableName(columnNumber);
> this.columnTypeName = rsmd.getColumnTypeName (columnNumber);
> this.columnType = rsmd.getColumnType (columnNumber);
> @@ -402,4 +402,4 @@
> {
> return tableName;
> }
> -}
>
> --
> Hakan Tandogan [EMAIL PROTECTED]
>
> "Any sufficiently advanced bug is indistinguishable from a feature"
>
> ------------------------------------------------------------
> To subscribe: [EMAIL PROTECTED]
> To unsubscribe: [EMAIL PROTECTED]
> Problems?: [EMAIL PROTECTED]
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
