I added a couple of the patches you submitted earlier.  Regarding the
addition of methods to User:
in my opinion it is best to limit changes to User.  I went ahead and added
one of the suggested methods because it was necessary to remove the
TurbineUser reference in a method in UserFactory.  No calls are made to
UserFactory.retrieveFromStorage(int) in any Turbine classes, but I assume it
was being used by someone, so I did not want to remove the method.

Let's try to limit changes to User. (Of course, suggestions are welcome for
changes that might be implemented after we settle on a version 1.0).
Thanks,
John McNally


>
> Is this the proper method for submitting patches? This is the third
> patch I've sent in the last week and with the first two I didn't hear a
> single comment on whether they were appropriate or not. We are making
> extensive use of the Turbine framework in our projects and there are
> many things that we will want to contribute back into the framework but
> I'm unclear on the best way to do that.
>




------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Problems?:           [EMAIL PROTECTED]

Reply via email to