Ok,
I see a few inconsistencies and I would like to propose the solutions which
I would like the active participants to vote on (this is the incentive to
participate!).
The following files are in the wrong packages in my opinion:
org.apache.turbine.util.TurbineUser.java
org.apache.turbine.util.TurbineUserPeer.java
org.apache.turbine.util.User.java
org.apache.turbine.util.access.UserFactory.java
org.apache.turbine.util.access.VisitorRolePeer.java
I propose that we make a new package in the org.apache.turbine.util package
and call it "user" or "visitor" (please vote) and then place the above files
into that package.
The reasoning is that these files all deal with the user management and
should be on their own to make it clear that these are the files that you
should override/replace if you are going to implement your own user
management stuff.
I definitely feel that in the least, the VisitorRolePeer and UserFactory
should be removed from the access package.
In fact, after thinking about this further, I think that we should rename
the "access" package to "security" since that is more of what the files
(roles/permissions/ACL/logonfailedexception) in there are providing.
Now, even more thinking, I propose to rename "LogonFailedException" to be
"LoginFailedException" to be more consistent with the "Login" screen and
action names.
Comments?
<side note>
Jikes 1.11 compiles OPaL correctly now. Whoo hoo!
</side note>
thanks,
-jon
--
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
