> 
> Localization.getString(s)
> Localization.getString(data, s)
> 
> These two methods will always return the "default" bundle which right now is
> the file "default.properties".

Actually, it seems that ResourceBundles use .class files and not .property
files. The class would be default.java. Ok. I see now why my code won't
work for shit right now. ;-(

> We can change this so there is a prop in
> TurbineResources with something like
> local.default.bundle=ARealBundle.properties.  But that ties the convenience
> methods in Localization to a *single* props file.

Actually, it should be just the name of the .class file. This is a good
solution. It would not restrict at all because this would just be the
baseName.
 
> I'm going to take out the two getString() methods in Localization and add
> getBundle() methods that correspond to the methods in
> TurbineLocalizationService instead.  That way we will just call
> Localization.getBundle("MyBundle").getString()
> 
> Let me know if there are any problems with this

I do have a problem with that. -1 on removing the getString() methods. I
put them in there for a reason to make it easier to get at the
default bundle information.

So, I vote +1 on adding another property which is the basename of the
default bundle and then fixing the static final String in
LocalizationService to use that value instead. I also vote +1 to adding a
Localization.setBundle() method that will allow you to override the
default static value.

cool?

-jon



------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Problems?:           [EMAIL PROTECTED]

Reply via email to