on 4/14/00 10:54 AM, Chris Meyer <[EMAIL PROTECTED]> wrote:
> What's the difference in usage between 'eval' and 'exec' in the
> loader classes? Are either of these overridden ever?
This is documented in the javadoc.
Essentially eval doesn't return a result and exec does (or visa versa, I
can't remember off the top of my head right now). Thus, Modules have the
option to return a value (ConcreteElement) or not.
> 1. Rename 'eval' and 'exec' to more descriptive names. If they're not
> used independently, merge them into a single method.
See my last message about making a lot of changes that will affect a lot of
code. ;-)
> 2. Make PageLoader and LayoutLoader follow the model of the other classes.
they already do. What is different?
> 3. Perhaps move all of this into a parent class which implements the
> duplicated code in one place.
Can't do that in order to cleanly maintain the interface stuff...
> 4. Instead of invoking 'build' directly, invoke another method like
> 'do_build' which invokes 'build'. I try to make abstract methods only
> invoked from INSIDE a particular class. This allows the class to
> change calling context of the abstract method easily.
It seems as though you thought about this whole bit more in your patch that
you sent after this message so I'm not going to comment on this again
because I already have. ;-)
> Again I apologize for the barrage of questions... Just trying to get
> to the point where I can make useful changes to the code.
No worries, just be VERY careful about making suggestions that might affect
large bodies of code. There are a lot of people using Turbine as it is. It
hasn't been released yet because I knew that some of these changes needed to
be made...but we still have to be careful of these things.
-jon
--
Scarab -
Java Servlet Based - Open Source
Bug/Issue Tracking System
<http://scarab.tigris.org/>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
