on 4/23/00 5:16 AM, Chris Kimpton <[EMAIL PROTECTED]> wrote:
> I'm trying to use Turbine with some existing tables - and thus producing
> my own map class and I'm finding a few quirks with integrating it -
> mainly due to spurious strings around the code, such as "VISITORID". So
> I'm going to submit a few patches to try and reduce these and ease my
> integration - but if they get integrated, I can still use the core
> Turbine.
>
> If I am stepping on anyones toes - sorry - its just that I am coding
> this today - so I either send this in, or diverge my copy of Turbine -
> and I don't want to lose all your support :-) If these patches are
> going in the wrong direction - let me know.
>
> So here is the first one - it should be standalone.
dude...you got rid of all the javadoc in there...:-(
send me a patch that has readable code in the format that is like the rest
of the project (ie: the code isn't all on one line) and also have javadoc.
if ( foo )
{
}
not
if ( foo ) {}
it may be readable to you, but it might not be readable by the next guy
working on this code. you need to respect that in an OS project. :-)
thanks,
-jon
--
Scarab -
Java Servlet Based - Open Source
Bug/Issue Tracking System
<http://scarab.tigris.org/>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
