ok, here's the diff...
Index: DynamicURI.java
===================================================================
RCS file:
/products/cvs/turbine/turbine/src/java/org/apache/turbine/util/DynamicUR
I.java,v
retrieving revision 1.15
diff -r1.15 DynamicURI.java
761c761
< output.append( request.getServletPath() );
---
> output.append ( data.getServerData().getScriptName() );
> -----Original Message-----
> From: Neeme Praks
> Sent: Thursday, May 04, 2000 7:54 PM
> To: Turbine
> Subject: RE: bug in DynamicURI.java?
>
>
>
> it should work because that's the way it is done in toString() method
> (without arguments). I'll test and prepare a diff...
>
> Neeme
> > -----Original Message-----
> > From: John McNally [mailto:[EMAIL PROTECTED]]
> > Sent: Thursday, May 04, 2000 7:47 PM
> > To: Turbine
> > Subject: Re: bug in DynamicURI.java?
> >
> >
> > I think this should be handled by replacing
> > request.getSerlvletPath() with
> > data.getScriptName() in the toString method. RunDataFactory
> > is already
> > trying to account for the difference in jsdk's. Please try
> > this route and
> > submit patch if it works.
> >
> > John
> >
> > ----- Original Message -----
> > From: Neeme Praks <[EMAIL PROTECTED]>
> > To: Turbine <[EMAIL PROTECTED]>
> > Sent: Thursday, May 04, 2000 9:09 AM
> > Subject: RE: bug in DynamicURI.java?
> >
> >
> > >
> > > i'm using Tomcat, so it could be Tomcat "feature"...
> > >
> > > > -----Original Message-----
> > > > From: John McNally [mailto:[EMAIL PROTECTED]]
> > > > Sent: Thursday, May 04, 2000 5:41 PM
> > > > To: Turbine
> > > > Subject: Re: bug in DynamicURI.java?
> > > >
> > > >
> > > > I think getServletPath should return the whole path, it is
> > > > supposed to give
> > > > the part of the path referring to the servlet. What servlet
> > > > engine are you
> > > > using? Also, I do not think getContextPath is in jsdk2.0.
> > > > If this is a
> > > > "bug" in Tomcat or some other popular servlet engine maybe we
> > > > should provide
> > > > support for both through reflection. If it is a bug in Sun's
> > > > implementation
> > > > of jsdk2.1, I would suggest changing servlet engines.
> > > >
> > > > ----- Original Message -----
> > > > From: Neeme Praks <[EMAIL PROTECTED]>
> > > > To: Turbine (E-mail) <[EMAIL PROTECTED]>
> > > > Sent: Thursday, May 04, 2000 5:00 AM
> > > > Subject: bug in DynamicURI.java?
> > > >
> > > >
> > > > > Hi all!
> > > > >
> > > > > After playing around with Turbine a little, I found
> > something that I
> > > > > would call a bug ;-)
> > > > > When DynamicURI generates an URI from RunData object,
> > method "public
> > > > > static String toString(RunData data)", there is the line
> > > > that appends
> > > > > the servlet path into the URI:
> > > > > output.append( request.getServletPath() );
> > > > >
> > > > > This returns the servlet path, but doesn't return the
> > application
> > > > > context. So when I request the following URL:
> > > > >
> http://localhost:8080/turbine/servlet/Turbine/screen/HelloWorld
> > > > > it returns "/servlet/Turbine", but doesn't return the context
> > > > > "/turbine".
> > > > > So, the code should be patched to also append the context:
> > > > >
> > > > > Index: DynamicURI.java
> > > > >
> > ===================================================================
> > > > > RCS file:
> > > > >
> > > > /products/cvs/turbine/turbine/src/java/org/apache/turbine/util
> > > > /DynamicUR
> > > > > I.java,v
> > > > > retrieving revision 1.15
> > > > > diff -r1.15 DynamicURI.java
> > > > > 760a761
> > > > > > output.append( request.getContextPath() );
> > > > >
> > > > > I hope it is correct?
> > > > >
> > > > > Also i don't understand why do you always want to redirect in
> > > > > turbine.java. Can't I have a functionality that when a new
> > > > user requests
> > > > > a page, turbine simply creates an anonymous user object and
> > > > returns the
> > > > > requested page. Why all the redirecting if I don't require
> > > > the user to
> > > > > log in?
> > > > >
> > > > > Neeme
> > > > >
> > > > > PS. I'm very new to the whole Java/Turbine/OSS/CVS world,
> > > > so I hope that
> > > > > my patch was accurate. After all it is my first
> bugfix in an OSS
> > > > > project. Oh, I feel excited ;-)
> > > > >
> > > > >
> > > > > ------------------------------------------------------------
> > > > > To subscribe: [EMAIL PROTECTED]
> > > > > To unsubscribe: [EMAIL PROTECTED]
> > > > > Problems?: [EMAIL PROTECTED]
> > > >
> > > >
> > > >
> > > > ------------------------------------------------------------
> > > > To subscribe: [EMAIL PROTECTED]
> > > > To unsubscribe: [EMAIL PROTECTED]
> > > > Problems?: [EMAIL PROTECTED]
> > > >
> > > >
> > >
> > >
> > > ------------------------------------------------------------
> > > To subscribe: [EMAIL PROTECTED]
> > > To unsubscribe: [EMAIL PROTECTED]
> > > Problems?: [EMAIL PROTECTED]
> >
> >
> >
> > ------------------------------------------------------------
> > To subscribe: [EMAIL PROTECTED]
> > To unsubscribe: [EMAIL PROTECTED]
> > Problems?: [EMAIL PROTECTED]
> >
> >
>
>
> ------------------------------------------------------------
> To subscribe: [EMAIL PROTECTED]
> To unsubscribe: [EMAIL PROTECTED]
> Problems?: [EMAIL PROTECTED]
>
>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
