on 5/8/2000 9:20 PM, dave bryson <[EMAIL PROTECTED]> wrote:

> The first problem was the WebMacro.properties file was using
> the old parameter TemplateTools - instead of ContextTools for the
> new WM jars, I've updated it in the CVS.

Ug. I may have not checked in the latest WM.properties file that I was
using. I apologize. I will reconfirm that ASAP.

> However, line 133 in the WebMacroSitePage throws a null pointer
> exception.  I think this is a problem depending upon which
> SessionValidatior you are using. Line 133 sets the WMContext in the
> data.users.setTemp(). This is a problem if the user has not logged in
> or has not be given a "guest" account. ( data.user = null)

Yes, you are right on. I have documented this...read the javadoc. :-)

> Jon, what session validator are you using to get around this?

Essentially the one from jyve minus the Jyve specific stuff. We may wish to
modify the default SessionValidator to at least create a guest user so that
others do not run into this problem.

As always, my source code is fully available:

<http://scarab.tigris.org/source/browse/scarab/src/java/org/tigris/scarab/mo
dules/actions/ScarabSessionValidator.java?rev=1.2&content-type=text/x-cvsweb
-markup>

> I also think there may be a better way to do this by using a
> TemplateInfo class the John M and I have talked about before. The
> TemplateInfo class would live in the RunData object and would hide all
> the - data.getParameters().getString("template", null) calls, etc.  It's
> also the first step towards reducing a lot of the duplication in code.
> 
> Thought?

+1. I have also thought that it might be nice to have a getTemp() method in
RunData (that is just a wrapper around another Hashtable) that does not
depend on having a valid User record around. That way, we could stuff
endless amounts of stuff in there that isn't session bound, but is only
request bound. My only fear is that it would confuse people with two
getTemp() methods so close to each other.

data.getTemp()
vs.
data.getUser().getTemp()

Comments?

> I've already started the TemplateInfo, but haven't commited yet because
> I've been dorking with WM configuration for the last 2 days!

Ug. I'm sorry about that. Please send me email when you have problems like
that as I'm happy to help. If it makes you feel any better, it took me about
that long to get up to speed with the changes that you made....hence my
recent push to document things while they were fresh in my memory. :-)

-jon

-- 
    Java Servlet Based - Open Source  |        Collab.Net
        Bug/Issue Tracking System     |   now hiring smart people
       <http://scarab.tigris.org/>    |  <http://Collab.Net/jobs/>



------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Problems?:           [EMAIL PROTECTED]


Reply via email to