Hi,
> I don't entirely like what you are doing in your code
Which bits don't you like? (theres always room for improvement...)
Anyway, while the iron is hot - here is the patch...
Index: src/java/org/apache/turbine/om/user/TurbineUser.java
===================================================================
RCS file:
/products/cvs/turbine/turbine/src/java/org/apache/turbine/om/user/TurbineUser.java,v
retrieving revision 1.3
diff -r1.3 TurbineUser.java
545a546,550
> //newUser - default to false,
> boolean newUser = false;
> if (getId() == NEW_ID)
> newUser = true; // need to do an insert
>
552c557,561
< criteria.add( TurbineUserPeer.VISITOR_ID, getId() );
---
>
> if (newUser)
> criteria.add( TurbineUserPeer.VISITOR_ID, TurbineUserPeer.getNextId()
>);
> else
> criteria.add( TurbineUserPeer.VISITOR_ID, getId() );
563c572,576
< TurbineUserPeer.doUpdate(criteria);
---
>
> if (newUser)
> TurbineUserPeer.doInsert(criteria);
> else
> TurbineUserPeer.doUpdate(criteria);
cvs server: Diffing src/java/org/apache/turbine/om/user/peer
Index: src/java/org/apache/turbine/om/user/peer/TurbineUserPeer.java
===================================================================
RCS file:
/products/cvs/turbine/turbine/src/java/org/apache/turbine/om/user/peer/TurbineUserPeer.java,v
retrieving revision 1.16
diff -r1.16 TurbineUserPeer.java
325a326,333
>
> /**
> utility method to ease accessing the sequence
> */
> public static int getNextId() throws Exception
> {
> return getNextId(SEQUENCE_NAME);
> }
---
"There is no spoon"
______________________________________________
FREE Personalized Email at Mail.com
Sign up at http://www.mail.com/?sr=signup
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
