Hi, Daniel
----- Original Message -----
From: Daniel L. Rall <[EMAIL PROTECTED]>
To: Turbine <[EMAIL PROTECTED]>
Sent: Tuesday, July 04, 2000 10:52 PM
Subject: Re: NewGenerateMapBuilderTask compile err
> > The first should probably read "File.separator", but I can't understand
the
> > second. Changing s to "s" does not make any sense and there is no s
> > variable that provides an obvious solution. Could you maybe help me
with
> > this error?
>
> This patch renames the getPackages() method--which is perhaps misnamed
> as it only returns *one* package name, the name of the package for which
> the map is being generated--to getPackage(). It removes one extraneous
> line of code from the getPackageAsPath() method, and hopefully corrects
> the crud which was causing the compiler errors. It also adds JavaDoc to
> that method. I changed the private member "packages" to "packageName".
> Also, note the spots marked HELP where some paths that are concatenated
> together may not have file separators. Thoughts on these changes?
At least now I don't get compiler errors :-)
Just had a quick look at getPackageAsPath(). Everywhere it is used
(including HELP spots, but also elsewhere) it seems as if the assumption is
that there is a separator character at the end of the path that is returned.
Shouldn't getPackageAsPath() add a separator at the end of the path that
gets returned? That's probably where the "+s" came from?
Do you think we should check if rootdir has a separator at the end? Maybe
add some code in setRootdir() to make sure that the root dir will always be
valid.
~ Leon
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
