On Mon, 24 Jul 2000, Jon Stevens wrote:

> on 7/24/2000 3:50 PM, "Jason van Zyl" <[EMAIL PROTECTED]> wrote:
> 
> > Next is cleanup
> 
> Jason:
> 
> A few initial comments on Torque. Everything looks great. I just have a few
> minor nits.
> 
> #1. Please add javadoc to all of the classes and methods. This is outlined
> as a requirement in the code conventions document on the site. I'm going to
> be a major butthead about this requirement. Documentation of this stuff is
> an absolute necessary. This isn't something that can be done later...it has
> to be done now.

Absolutely not a problem! It will be javadoc'd by tomorrow. I agree
that it's a necessity, no buttheadedness taken :)

> 
> #2. You have some String utility methods. Please consider adding them to
> org.apache.turbine.util.StringUtil instead.

I'll move them in there tonight! I just wanted to keep it
self-contained to start.

jvz.

-- 

Jason van Zyl
[EMAIL PROTECTED]



------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to