> -----Original Message-----
> From: Jeff Brekke [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, August 08, 2000 2:26 PM
> 
> First off, thanks for the recent contributions to Turbine.  I 
> apologize for
> not catching this before you commited.
> 
> * the FileHandler.java file is blowing the build when using 
> jsdk2.0 when you
> try to set the buffer size of the response.
> 
> turbine/bin/src/org/apache/turbine/util/FileHandler.java:96: Method
> setBufferSize(int) not found in interface
> javax.servlet.http.HttpServletResponse.
>         res.setBufferSize(writebuffersize);

ok, sorry for this. We'll (I'm not the original author) try to come up
with a solution to this.

> * Please javadoc all methods and constructors per the coding 
> guidelines

ok, hopefully this week. ;-)

> * Can this file handler upload multiple files?  How would you go about
> allowing the user to select multiple files?  Input type of 
> FILE only allows
> one selection, or is there a MULTIPLE=true attribute that I'm 
> missing?  

well, I'm not sure how to make the browser to send multiple files... The
spec allows this and maybe some browsers also support this... dunno
exactly.

Actually, there are some bugs related to handling multiple files: right
now it adds the filenames of uploaded files to the parameterparser under
some special names (that are available as static constants on
filehandler class). I'm afraid that if you upload more than one file,
second filename will replace the first one... Should add them like and
array, but didn't have the need nor time to implement it right now.

> Thanks again for the code!

thanks for Turbine! ;-)

Neeme


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to