> So I was able to get in a state where the code
> in Turbine.java:reallyScrewedNow is run. The problem is
> how it handles the exception. If the exception is thrown
> and data is still null, then you get another exception (NullPointer)
> which masks the exception that you really care about.
>
> I don't have cvs rights (hopefully someday). So I am including
> the patch. Also, I took the liberty of factoring out some repeated
> code and cleaned up the comments to be consistent. One of my
> two coding pet peeves is code that spills over 80 columns. So I also
> fixed that. I hoped this dosen't step on anyone's toes.
> Here's the diff:
<snip>
As an Emacs user, I wholeheartedly agree with you concerning >80 column lines.
However, for the sake of a useful revision history, formatting changes should
always be separate from functional changes. Please re-submit your diff with
functional changes only.
As far as code formatting goes, Gonzalo has been doing a great job of
cleaning-up >80 column lines and the like. Perhaps he hasn't gotten to this file
yet.
--
Christopher Elkins
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
