> AFAIK, the only libs where the license is an issue is WebMacro. There are
> currently two pairs of WM jars (one each for JDK 1.1 and JDK 2) in the lib
> directory: webmacro-jdk1.x-CVS.jar is under the GPL, while
> webmacro-jdk1.x-27-08-2000.jar is under an Apache-style license. The reason
for
> the multiple versions is that an interface changed between them, and I don't
> know enough about WM to fix the problem. Once we can remove the older WM jars,
> all the libs should be redistributable without issue. However, IANAL, so don't
> quote me on that. ;-)
>
Can someone _please_ fix TurbineWebMacroService to use the latest WM jars in
CVS. Once this is fixed, I can remove those old WM jars, and turbine/lib will
finally be GPL-free. To rehash the previous thread:
Christopher Elkins wrote:
> Great...exactly what I was afraid of: the org.webmacro.Template interface has
> changed, which is breaking TurbineWebMacroService. I can describe the problem,
> but I don't know enough about WM to fix it safely. Here's the error:
>
>
C:\Projects\jakarta\turbine\bin\src\org\apache\turbine\services\webmacro\Turbine
> WebMacroService.java:211: Method write(java.io.Writer,
> org.webmacro.servlet.WebContext) not found in interface org.webmacro.Template.
> template.write(out, wc);
>
> Template.write() now takes a FastWriter as the first param (see
> org.webmacro.Macro for the inherited method). This is probably going to
require
> a refactoring of TurbineWebMacroService.handleRequest(). Any takers?
Justin Wells wrote:
> It was mentioned in the release email and in the README.html: you have to
> come up with a FastWriter somehow now. It makes a *huge* difference in
> performance since it writes the static data out the pipe without doing
> the really expensive byte-by-byte unicode conversion.
>
> It breaks things but the fix is trivial:
>
> FastWriter = new FastWriter(...);
>
> You need to come up with an outputstream and decide on an encoding.
The problem (based on my cursory and simple-minded examination ;-)) is that
FastWriter needs to call data.getResponse().getOutputStream(). This doesn't seem
like a very good thing, but I could easily be wrong. It seems this fix requires
someone with more in-depth knowledge of the Turbine/WM integration than I
currently have. :-)
Also, I'm not entirely sure that webmacro-jdk1.1-27-08-2000.jar is actually
compiled for JDK 1.1. Formerly, the webmacro.jar contained in snapshots was
compiled for JDK 1.1, and you had to re-compile the source for JDK 1.2. I
_think_ Justin reversed this (based on some messages on the WM list), but the
docs weren't updated in concert. I may just bite the bullet and re-compile it
for JDK 1.1 so that I can be sure, but I _really_ didn't want to install JDK
1.1.
--
Christopher Elkins
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
