Hi!

I would like to propose a fix to a problem that manages to piss me off
once in a while, just like today. When there is an uncaught exception
(throwable to be specific, because NoClassDefFoundErrors are common
in this context) during request processing, it ends up in the 
Turbine.handleException. Unfortunately in very common situations it 
fails to make it to the browser, and the logging of the exception
is attempted only in 'reallyScrewedNow' part. This results in mysterious
'The server response contained no data' (Netscape) / 'funny blank page' (IE)
with no trace in the log what happed... I really hate that. This is the 
patch that solves the problem:

--cut---------------------------------------------------------------------
diff -u -r1.12 Turbine.java
--- Turbine.java        2000/09/07 18:49:25     1.12
+++ Turbine.java        2000/09/12 18:27:08
@@ -552,6 +552,9 @@
                                  HttpServletResponse res,
                                  Throwable t)
     {
+        Log.error("Turbine.handleException:");
+        Log.error(t);
+    
         String mimeType = "text/plain";
         try
         {
--cut---------------------------------------------------------------------

If noone objects, I'll check it in tomorrow.

Rafal


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to