Sorry if this seems petty, but it seems to me that TurbineResources gets
used a little sloppily sometimes, in that people often write:
String some_value = TurbineResources.getString("some_string_key");
instead of:
String some_value =
TurbineResources.getString(TurbineResources.SOME_STRING_KEY);
where SOME_STRING_KEY is publicly defined in TurbineResources. I've always
felt that hard-coded strings should only be defined once. Would it be worth
it to anyone if I cleaned these strings up, or is there some reason things
are done this way (I'm new around here and sometimes lose the subtlties)?
For that matter, don't you think most of the default values should be stored
in TurbineResources.java too? That way you could call:
String some_value =
TurbineResources.getString(TurbineResources.SOME_STRING_KEY,
TurbineResources.SOME_DEFAULT_VAL);
And only have to change SOME_DEFAULT_VAL in one place rather than several.
Chris
[EMAIL PROTECTED]
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
