on 11/28/2000 9:22 AM, "Mike Haberman" <[EMAIL PROTECTED]> wrote:

> It seems that in order for named anchors to work properly, the '#'
> must not be encoded (via URLEncoder).  I would think that browsers
> should be able to handled the encoded '#' but they don't.
> 
> I have the fix and am ready to commit it to cvs, but was wondering
> if anyone else has any comments on this.
> 
> This will affect any calls to $link.setPage() that contain a hash
> mark.
> e.g $link.setPage("admin,index.wm#markMe")
> 
> Also,  there is a lot of unnecessary object (StringBuffer) creation.
> I will commit the fix for that as well.

Not enough detail being explained here.

Before you commit this patch, post it to the list.

Creating StringBuffer's is better than doing

String foo
String bar

String ack = foo+bar

Strings cannot be modified so you end up creating a bazillion other strings
if you do the above.

-jon

-- 
twice of not very much is still a lot more than not very much



------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to