Rafal Krzewski <[EMAIL PROTECTED]> writes:

> Santiago Gala wrote:
> 
> > Wouldn't it be better to mark all Threads started for Turbine like
> > daemon threads using setDaemon()?
> > 
> > In this way, the VM could stop without hard measures like hitting CTRL-C
> > or calling exit().
> > 
> > I don't know if it could bring any problem, but it looks simple to add a
> > setDaemon call to any service as it is started. Is it a bad idea?
> 
> This sounds like an excelent idea to me. WebMacro is outside of our
> control
> but the threads spawned by Turbine could use it right away.
> 
> I just made a quick grep -r that revealed a number of threads that may
> be started by Turbine:
> 
> GlobalCacheService (for items expiry/refresh)
> TurbineSchedulerService has its own thread, and also spawns
> WorkerThreads
> (the WorkerThreads should not be treated as daemon threads)
> IDBroker uses a thread
> LargeSelect class performs some operation in a separate thread, but it
> should be treated as user thread rather than daemon.
> 
> I'm +1 to making the threads of GlobalCache, Scheduler and IDBroker
> daemon threads.
> If there are no voices agains that I'll comit the changes in a few days.
> 
> Rafal
> 
> PS. Thanks for the idea Santiago!

I am strongly +1 on this as well.

Daniel


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to