[EMAIL PROTECTED] wrote:
>
> I finished the patch for making the resources service of Turbine
> pluggable.
Great! I'll try to incorporate your patch ASAP.
> The files are located at:
> http://locus.apache.org/~raphael/turbine/
>
> This patch allows the resources service implementation to be selected
> by a startup servlet parameter.
> However, people wishing to implement new resources service implementation
> should carefully read the limitations described in ResourcesService.java
> because there a lot of Turbine functionalities are unavailable to this service
> since it's initialized in a bootstrap mode.
>
> An alternate implementation of the resources services can be found in the
> Jetspeed CVS.
What is the difference? Do you think that Jetspeed's implementaition is
generic
enough to be included in Turbine, or can easily be made generic?
> I've taken great care to be backward compatible with the previous implementation
> so the old TurbineResourceService.setPropertiesFileName() still works but is
> deprecated.
If there is a meaningful way of initializing Turbine both in Servlet
environment
and standalone (through org.apache.turbine.util.TurbineConfig class) we
can
safely remove this method.
> One caveat:
> In order to be backward compatible, I had to make the InvalidResourcesException
> a RuntimeException so that exising code does not need to explicitely catch
> this exception but the Turbine servlet can if it wants.
>
> This is not very good but I trust Rafal will make this service compliant
> to the TurbineException model :)
I find your approach perfectly valid. The application code has the right
to expect
that the system is correctly configured. The ResourcesService should
throw a
Runtime-flavour exception, and the Servlet will inform the administrator
that
something's screwed up.
All I need to do is to introduce TurbineRuntimeExcption into your code,
and wrap
any underlying exceptions into that.
I'm thinking about 'the great reanaming' of the services you recenlty
proposed.
Did you know that I proposed the very same thing a few months ago? I
didn't
quite have the nerve to do that, as it would break *all* Turbine apps
around.
This definetely needs to be done before the release, so I'll do that as
a part
of my current work on services framework.
Rafal
--
Rafal Krzewski
Senior Internet Developer
mailto:[EMAIL PROTECTED]
+48 22 8534830 http://e-point.pl
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
