I just worked a change into Ant's Commandline.java that fixes the 
problem.  I will be sending a patch to the Ant list just shortly, but 
I'm not really convinced that they'll take it - reason being, if 
System.getProperty("file.separator") != "/", then it replaces all 
occurrences of / in the command to file.separator, which COULD be a bad 
thing to do if there happens to be a command line with /'s in it that 
need to actually be /'s.

I have an ant.jar with that worked in, though, if you'd like to take a 
gander at it.

Will Stranathan

Jason van Zyl wrote:

> 
> On Mon, 1 Jan 2001, Will Stranathan wrote:
> 
> 
>> Agreed on both - like I said, temportary (and ugly) solutions.
>> 
>> Incidentally, I just discovered that Ant will read system properties 
>> properly, so instead of setting a targetPathSeparator for the first 
>> issue, I managed to make it work with ${file.separator}.
> 
> 
> I was hoping that ant would flip the anything that looked like
> a path into the ${file.separator} automatically. I think this
> is how it normally works so I'm not sure why it's not working
> for the path to a script that is to be executed?
> 
> jvz.
>  
> 
>> Will Stranathan
>> 
>> Jason van Zyl wrote:
>> 
>> 
>>> On Mon, 1 Jan 2001, Will Stranathan wrote:
>>> 
>>> 
>>> 
>>>> I don't like them too much - they're not very elegant, but I have some 
>>>> fixes for a coupld of issues on the build-project script for a project 
>>>> under the TDK.
>>>> 
>>>> 1) On Windows NT or 2000, the <exec> task in Ant tries to call a literal 
>>>> ../src\sql\create-database.bat.
>>>> 
>>>> I *think* this is an Ant issue and the CORRECT fix would be to fix 
>>>> things in Ant.
>>>> 
>>>> However, a workaround is to set a targetPathSeparator in 
>>>> [appname].properties to \\ on Windows, then change the <exec> task in 
>>>> build-project.xml to read something like:
>>>>   <exec 
>>>> 
>executable="..${targetPathSeparator}src${targetPathSeparator}sql${targetPathSeparator}${script}"/>
>>> 
>>> 
>>> I would rather find a better way to deal with this and I'm sure someone
>>> has already dealt with this issue. We should deal with it in Ant,
>>> there are already a couple of platform specific things that I
>>> would like to get rid of. I would really prefer not to add another
>>> one.
>>> 
>>> 
>>> 
>>>> The problem with this is that %{outputDirectory} was used previously.  I 
>>>> figured since it was set in the section in [appname].properties in the 
>>>> area underneath You should NOT have to edit anything underneath here, 
>>>> that it would be OKAY as a temporary solution to hard-code the same path 
>>>> into the build-project.xml.
>>> 
>>> 
>>>> 2) On Windows, \n's (CRLF's) are treated as 2 characters, so the chop 
>>>> commands in the Torque templates are not actually chopping the trailing 
>>>> comma.
>>>> 
>>>> Under build/bin/torque/templates, I created a windows directory and a 
>>>> unix directory.  I copied all the existing structure into those 
>>>> directories, and modified the templates in the windows directory to chop 
>>>> one extra character.  Then, in build-project.xml, I changed all the 
>>>> vtorque tasks that generate SQL to use ${templatePath}/${targetPlatform} 
>>>> for the templatePath.
>>> 
>>> 
>>> -1 
>>> 
>>> This has already been fixed and tested. And having two directories
>>> of templates would be a loathsome maintenance problem. The chop
>>> has been fixed and Martin has tested it under windows.
>>>  
>>> 
>>> 
>>>> Again, I'm not really sure I like the idea of having to keep separate 
>>>> templates for Windows and Unix.  But as a temporary solution, it's 
>>>> functional.
>>> 
>>> 
>>> 
>>>> I have these solutions available, but don't necessarily want to check 
>>>> them in, because they're really kludges, not real fixes.
>>> 
>>> 
>>> The double set of templates you definitely shouldn't check in. But
>>> if you can actually find a way to deal with the execution of
>>> scripts properly that would very much be appreciated. I'm sure
>>> there must be something in the Ant archives dealing with the
>>> problem you're finding.
>>> 
>>> jvz.
>>> 
>>> 
>>> 
>>> ------------------------------------------------------------
>>> To subscribe:        [EMAIL PROTECTED]
>>> To unsubscribe:      [EMAIL PROTECTED]
>>> Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
>>> Problems?:           [EMAIL PROTECTED]
>> 
>> 
>> 
>> ------------------------------------------------------------
>> To subscribe:        [EMAIL PROTECTED]
>> To unsubscribe:      [EMAIL PROTECTED]
>> Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
>> Problems?:           [EMAIL PROTECTED]
>> 
>> 
> 
> 
> 
> 
> ------------------------------------------------------------
> To subscribe:        [EMAIL PROTECTED]
> To unsubscribe:      [EMAIL PROTECTED]
> Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
> Problems?:           [EMAIL PROTECTED]



------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to