Single line String concatentation compiles to the same bytecodes as use
of a StringBuffer would, and is much more readable.
Java Apache CVS Development <[EMAIL PROTECTED]> writes:
> User: mcnally
> Date: 01/01/29 15:09:22
>
> Modified: src/java/org/apache/turbine/util/db Criteria.java
> Log:
> declare proper size of StringBuffer for better efficiency.
>
> I think a simple table + "." + column should work here and be compiled correctly
>for maximum efficiency, but it does not hurt to make sure.
>
> Revision Changes Path
> 1.13 +41 -18 turbine/src/java/org/apache/turbine/util/db/Criteria.java
>
> Index: Criteria.java
> ===================================================================
> RCS file:
>/products/cvs/turbine/turbine/src/java/org/apache/turbine/util/db/Criteria.java,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -r1.12 -r1.13
> --- Criteria.java 2001/01/29 22:58:50 1.12
> +++ Criteria.java 2001/01/29 23:09:21 1.13
> @@ -77,7 +77,7 @@
> * @author <a href="mailto:[EMAIL PROTECTED]">Frank Y. Kim</a>
> * @author <a href="mailto:[EMAIL PROTECTED]">John D. McNally</a>
> * @author <a href="mailto:[EMAIL PROTECTED]">Brett McLaughlin</a>
> - * @version $Id: Criteria.java,v 1.12 2001/01/29 22:58:50 mcnally Exp $
> + * @version $Id: Criteria.java,v 1.13 2001/01/29 23:09:21 mcnally Exp $
> */
> public class Criteria extends Hashtable
> {
> @@ -251,7 +251,9 @@
> public boolean getBoolean(String table,
> String column)
> {
> - return getBoolean( new StringBuffer(table).append('.').append(column)
> + return getBoolean(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -315,7 +317,9 @@
> private Criterion getCriterion(String table,
> String column)
> {
> - return getCriterion( new StringBuffer(table).append('.').append(column)
> + return getCriterion(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -351,8 +355,9 @@
> public String getComparison(String table,
> String column)
> {
> - return getComparison( new StringBuffer(table)
> - .append('.').append(column)
> + return getComparison(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -428,7 +433,9 @@
> public double getDouble(String table,
> String column)
> {
> - return getDouble( new StringBuffer(table).append('.').append(column)
> + return getDouble(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -456,7 +463,9 @@
> public float getFloat(String table,
> String column)
> {
> - return getFloat( new StringBuffer(table).append('.').append(column)
> + return getFloat(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -484,7 +493,9 @@
> public Integer getInteger(String table,
> String column)
> {
> - return getInteger( new StringBuffer(table).append('.').append(column)
> + return getInteger(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -512,7 +523,9 @@
> public int getInt(String table,
> String column)
> {
> - return getInt( new StringBuffer(table).append('.').append(column)
> + return getInt(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -540,8 +553,9 @@
> public BigDecimal getBigDecimal(String table,
> String column)
> {
> - return getBigDecimal( new StringBuffer(table)
> - .append('.').append(column)
> + return getBigDecimal(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -569,7 +583,9 @@
> public long getLong(String table,
> String column)
> {
> - return getLong( new StringBuffer(table).append('.').append(column)
> + return getLong(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -594,7 +610,9 @@
> public String getString(String table,
> String column)
> {
> - return getString( new StringBuffer(table).append('.').append(column)
> + return getString(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -630,7 +648,9 @@
> public Vector getVector(String table,
> String column)
> {
> - return getVector( new StringBuffer(table).append('.').append(column)
> + return getVector(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -655,7 +675,9 @@
> public Object getValue( String table,
> String column )
> {
> - return getValue( new StringBuffer(table).append('.').append(column)
> + return getValue(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column)
> .toString() );
> }
>
> @@ -781,9 +803,10 @@
> Object value,
> String comparison )
> {
> - super.put( new StringBuffer(table).append('.')
> - .append(column).toString(),
> - new Criterion(table, column, value, comparison) );
> + super.put(
> + new StringBuffer(table.length() + column.length() + 1)
> + .append(table).append('.').append(column).toString(),
> + new Criterion(table, column, value, comparison) );
> return this;
> }
>
>
>
>
>
--
Daniel Rall <[EMAIL PROTECTED]>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
