On Wed, Feb 07, 2001 at 01:49:11PM +0100, Oskar ?wida wrote:
> OK, this is not a patch, rather two new methods for BasePeer class.
> Look at them,please and send comments
Okay, some comments:
Firstly your code is hard to read, please read the coding standards for
Turbine document <http://java.apache.org/turbine/code-standards.html>.
Secondly patches are not hard to generate - make sure you have up to
date sources from CVS, make the modifications to the checked out copy,
and then run 'cvs diff -u BasePeer.java' (for example). This list won't
accept attachments so _insert_ it into your email (being careful not to
let your email client wrap lines).
Thirdly the first method looks ok, but I don't see what the second one
buys me over doSelect(criteria).size() . There is still the overhead of
building a vector full of data objects. If you could arrange to do a
select like the first but using the Criteria object to build the WHERE
clause, now that would be a method worth having.
Cheers,
Sean
--
Sean Legassick
[EMAIL PROTECTED]
As a man, nothing human can be alien to me
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
