if i set
private final static boolean debug = true;
in TurbineConfig.java i get
Turbine: init
Turbine: Turbine: init() failed:
org.apache.turbine.services.InstantiationException: ServiceBroker:
unknown service TurbineLoggingService requested
at
org.apache.turbine.services.BaseServiceBroker.getServiceInstance(BaseServiceBroker.java:311)
at
org.apache.turbine.services.BaseServiceBroker.getService(BaseServiceBroker.java:256)
at org.apache.turbine.util.Log.info(Log.java:262)
at
org.apache.turbine.util.TurbineConfig.getRealPath(TurbineConfig.java:184)
at
org.apache.turbine.util.ServletUtils.expandRelative(ServletUtils.java:111)
at
org.apache.turbine.services.resources.TurbineResourceService.init(TurbineResourceService.java:154)
at
org.apache.turbine.services.resources.TurbineResourceService.init(TurbineResourceService.java:121)
at
org.apache.turbine.services.BaseInitableBroker.initClass(BaseInitableBroker.java:154)
at
org.apache.turbine.services.BaseServiceBroker.initService(BaseServiceBroker.java:120)
at
org.apache.turbine.services.TurbineServices.initPrimaryServices(TurbineServices.java:185)
at org.apache.turbine.Turbine.init(Turbine.java:180)
at
org.apache.turbine.util.TurbineConfig.init(TurbineConfig.java:157)
at addman.AddMan.<init>(AddMan.java:72)
at addman.AddMan.main(AddMan.java:143)
Exception in thread "main"
org.apache.turbine.services.InstantiationException: ServiceBroker:
unknown service TurbineLoggingService requested
at
org.apache.turbine.services.BaseServiceBroker.getServiceInstance(BaseServiceBroker.java:311)
at
org.apache.turbine.services.BaseServiceBroker.getService(BaseServiceBroker.java:256)
at org.apache.turbine.util.Log.error(Log.java:455)
at org.apache.turbine.util.Log.error(Log.java:534)
at addman.AddMan.<init>(AddMan.java:81)
at addman.AddMan.main(AddMan.java:143)
* so should i change
Log.info("getRealPath: " + path);
to
log("getRealPath: " + path);
to write to System.out??
* or check if Logging is available, remove the debug variable and use
Log.debug() ???
in TurbineServices there is
private boolean enabledLogging = false;
i would like to add a getter to see if the logging -service is
available
in TurbineServices:
public void error(Throwable t)
{
if (enabledLogging)
{
LoggingService
logger=(LoggingService)getService(LoggingService.SERVICE_NAME);
if (logger==null)
{
System.out.println("(!) ERROR: "+t.getMessage());
return;
}
logger.error("",t);
}
else
{
System.out.println("ERROR: "+t.getMessage());
t.printStackTrace();
}
}
* how can logger be null?? there will be a npe in
BaseServiceBroker.getService()
* why not simply call Log.error?
* why does the code not match the code conventions? ;-)
i found some other calls to the LoggingService class could they all be
changed to Log.x() ???
martin
ps: sorry if i missed something .. it's late ;-)
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
