I don't really understand your answer.
You told me that setting the id in the method for auto-incremented tables
does not cover all paths of course.
Don't you think that, throw the two lines I added, all paths would be
covered?

Thank you very much,

Michela



Please respond to "Turbine" <[EMAIL PROTECTED]>

To:   "Turbine" <[EMAIL PROTECTED]>
cc:
Subject:  Re: [PATCH]BasePeer.java


[EMAIL PROTECTED] writes:

> It seems to me that there is a bug in doInsert method of BasePeer.java.
> If the criteria already contains the primary key, such method returns
> null.
>
> Is there any reasons for such choice?
>
> Thank you very much,
>
> Michela
>
>
>
>
> --- BasePeer.java.old   Thu Feb 22 16:18:14 2001
> +++ BasePeer.java       Thu Feb 22 17:09:30 2001
> @@ -734,6 +734,8 @@
>                  criteria.add( pk.getFullyQualifiedName(), id );
>              }
>          }
> +        else
> +          id = criteria.get (pk.getFullyQualifiedName());
>
>          // Set up Village for the insert.
>          TableDataSet tds = nul

It can be set later in the method for auto-incremented tables.  This
may not cover every path of course (as you pointed out).
--

Daniel Rall <[EMAIL PROTECTED]>


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]







------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to