I left a comment on the page, but overall this looks really good. If
someone with more experience using Visit will give it a nod, I am
ready to add it to main docs.
Looking at it though, I can't help but wonder why we are using this
kind of plugin system when setuptools provides one. IMO this:
def add_simple_visit_plugin():
log.info("Registering the SimpleVisitPlugin")
turbogears.visit.enable_visit_plugin(SimpleVisitPlugin())
turbogears.startup.call_on_startup.append(add_simple_visit_plugin)
Is a lot more work than adding the following line to your setup.py:
entry_points = {"turbogears.visit.plugin" : "SimpleVisitPlugin =
myproject.visitplugins:SimpleVisitPlugin"}
But I suppose that is an issue to bring up in the trunk. Sidetrack
aside, good job Patrick.
-Adam
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TurboGears Docs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/turbogears-docs?hl=en
-~----------~----~----~----~------~----~------~--~---
