#1587: Identity bug: Form field names with dots in the name don't work
------------------------------------------------------------+---------------
 Reporter:  streawkceur                                     |        Owner:  
Chris Arndt
     Type:  defect                                          |       Status:  
closed     
 Priority:  normal                                          |    Milestone:  
1.1.1      
Component:  Identity                                        |      Version:  
1.0.4b1    
 Severity:  normal                                          |   Resolution:  
fixed      
 Keywords:  needs tests, identity, nested variables filter  |  
------------------------------------------------------------+---------------
Comment (by chrisz):

 You're right, that pop_from_nested_dict method really adds too much
 complexity to the identity plugin. But on the other hand accessing only
 the necessary values without touching the rest is much more effective and
 elegant. When I measured identity_from_form in isolation with a small
 bunch of request params it was 7x faster using pop_from_nested_dict than
 using formencode to decode/encode the whole params dict. As I said, this
 is probably not measurable in practice for the whole stack, but anyway, I
 feel better with the more effective method.

 So I have now moved the pop_from_nested_dict method into the util module,
 documented it and added a solid unit test. It might be handy in other
 situations as well.

-- 
Ticket URL: <http://trac.turbogears.org/ticket/1587#comment:12>
TurboGears <http://www.turbogears.org/>
TurboGears front-to-back web development

-- 
You received this message because you are subscribed to the Google
Groups "TurboGears Tickets" group.
This group is read-only. No posting by normal members allowed.
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/turbogears-tickets?hl=en?hl=en

Reply via email to