I've fixed the ugly hack to the Schema at:
http://trac.turbogears.org/turbogears/attachment/ticket/613/ 
filter_extra_true2.patch

Never underestimate what util.py might contain... ;)

I'd like someone to comment on the SubmitButton thing... I'm not  
entirely sure but I think the test is deprecated. Apart from that, I  
think  2 is ready for the trunk...

Alberto

On 11/03/2006, at 16:37, Alberto Valverde wrote:

>
> I've just attached a patch at #613 for review.
>
> It adds to the schema a NullValidator  for every widget that has no
> validator. This acts like a placeholder so the schema doesn't filter
> possible input from the widget.
>
> All tests passing without modification, though there is a note at
> SubmitButton because I think one of the tests at test_forms is
> deprecated. Better explained there...
>
> I had to do an ugly, IMO, hack at the Schema to add a NullValidator
> for the fields "self", and "tg_errors". This is because the validate
> decorator sends the whole kw dict to the form to validate, including
> this 2 vars which should not be stripped. I'm sure our "decorator
> guru" can find a better alternative... ;)
>
>
> Here it is if anyone wants to comment: http://trac.turbogears.org/
> turbogears/attachment/ticket/613/filter_extra_true.patch
>
> Nice weekend to all :)
> Alberto
>
> On 11/03/2006, at 12:39, Kevin Dangoor wrote:
>
>>
>> On 3/11/06, Michele Cella <[EMAIL PROTECTED]> wrote:
>>> Maybe we can assign by default into the Widget class a default  
>>> String
>>> or Null validator, so the user doesn't need to pass it, then we
>>> override it with the passed one if specified.
>>
>> Yes, I think that's what I said yesterday... or roughly what I meant
>> to say. The default behavior should be to pass the string straight
>> through.
>>
>> Kevin
>>
>>
>
>
>


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk
-~----------~----~----~----~------~----~------~--~---

Reply via email to