Kevin Dangoor wrote:
> On 4/6/06, Michele Cella <[EMAIL PROTECTED]> wrote:
> > I would like to remove this evil isinstance and replace it with
> > something that checks the presence of a callable validate method, this
> > will let other home-grown widget system to take advantage of the
> > validate decorator and AFAIK we are already doing the same for
> > retrieve_css and retrieve_javascript.
>
> +1

Perfect, would you mind to doing this Simon? I don't want to mess up
controllers.py... :D

>
> This hack is not as bad as I thought since it doesn't directly
> reference SQLObject (something that would've made me most unhappy).
> But, I'd still say "+1" on ditching the hack. If we want some
> SQLObject friendly widgets, they should be separate.
>

Ok, that's also my opinion and the general one.

> >3) I would like to remove two (I think) useless widgets since I can't
> > see any use case fot them:
> >
> > Label (unused by TG core and by no one IMHO)
> > ImageButton (any example of using this as a widget)
>
> It sounds like Label has a use, and ImageButton seems almost useful.
> Let's keep them for now. We need a ticket to make sure all of the
> standard widgets include WidgetDescriptions.
>

Ok, let's keep them since they don't necessarily hurt. ;-)

Ticket: http://trac.turbogears.org/turbogears/ticket/727

So, I'm going to remove the mentioned hack. ;-)

Ciao
Michele


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk
-~----------~----~----~----~------~----~------~--~---

Reply via email to