Hi Max,

Good job....  :)



Looking at the final code, I have just one comment:

Should CalendarLangFileLinkDesc still exist ? After all, now it seems
to be very specific do CalendarWidgets...

BUT, if it makes sense to preserve this WidgetDescription, its name
should be changed from "Localizable JS Link" to something like
"CalendarLangFileLink" or "CalendarLangFile Link"...  (if you look at
the Widget Browser you will see 2 "Localizable JS Link")


Cheers


Roger



On 6/15/06, Max Ischenko <[EMAIL PROTECTED]> wrote:
>
> > Max, if you think the Calendar can and should use this version then go
> > ahead and do it, otherwise I think renaming your one to
> > LocalizableJSLink and the advanced one to CalendarLangFileLink makes a
> > lot of sense because ATM we have two things with almost the same name.
> > ;-)
>
> In Subversion now.
>
> This is backward-incompatible change though I doubt there were many users of 
> original LocalizableJSLink outside big_widgets.py.
>
>
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk
-~----------~----~----~----~------~----~------~--~---

Reply via email to