On 10/23/06, Jorge Godoy <[EMAIL PROTECTED]> wrote: > > > Gentlemen, > > please, lets be more careful with commits on the *stable* branch. I don't > think that changing the identity code like it was done is right since there > are some differences between the model that was used and the one available at > model.py, specially with regards to table names. I'm sorry I should had check if those models where different. they are not supposed to
is there anything different then the table name? http://trac.turbogears.org/turbogears/browser/branches/1.0/turbogears/visit/sovisit.py 81 class TG_Visit(SQLObject): 82 class sqlmeta: 83 table="tg_visit" 84 85 visit_key= StringCol( length=40, alternateID=True, 86 alternateMethodName="by_visit_key" ) 87 created= DateTimeCol( default=datetime.now ) 88 expiry= DateTimeCol() 89 90 def lookup_visit( cls, visit_key ): 91 try: 92 return cls.by_visit_key( visit_key ) 93 except SQLObjectNotFound: 94 return None 95 lookup_visit= classmethod(lookup_visit) http://trac.turbogears.org/turbogears/browser/branches/1.0/turbogears/qstemplates/quickstart/%2Bpackage%2B/model.py_tmpl 29 class Visit(SQLObject): 30 class sqlmeta: 31 table = "visit" 32 33 visit_key = StringCol(length=40, alternateID=True, 34 alternateMethodName="by_visit_key") 35 created = DateTimeCol(default=datetime.now) 36 expiry = DateTimeCol() 37 38 def lookup_visit(cls, visit_key): 39 try: 40 return cls.by_visit_key(visit_key) 41 except SQLObjectNotFound: 42 return None 43 lookup_visit = classmethod(lookup_visit) > > I don't consider this a critical bug that needed being fixed before releasing > 1.0 and breaking applications that went into production. > actually this fix a bug that I think your code was depending on that was introduced in http://trac.turbogears.org/turbogears/changeset/1604#file12 as you can see Kevin moved the sovisit code to check for a config entry and added the Visit table to model.py but didn't changed the variable so people changing their visit class in model.py where not getting anything out of it. > (And I just got to know that because a disk failed on a server and I > reinstalled TG and updated the 1.0 branch there.) > Anyway I'm sorry I didn't knew you where running out of a 1.0 co I'll be more careful. > > Be seeing you, > -- > Jorge Godoy <[EMAIL PROTECTED]> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/turbogears-trunk -~----------~----~----~----~------~----~------~--~---
