Oops I replied directly to Kevin on this. Also it's worth mentioning that Michael Bayer didn't particularly like this.
I think my preferred solution would be to put this in a decorator, and pull it out of the expose decorator in a run_with_transaction() decorator or something like that... But that is a syntactic change, so I think the way to do it now is to keep the current behavior and break this in 2.0. What do you all think? On 2/28/07, Mark Ramm <[EMAIL PROTECTED]> wrote: > > Yea, I think the simplest thing is to continue to do it the way we are. > > But I think it would be worth thinking about whether Identity's stuff > really needs to be wrapped in a transaction: we're just updating the visit > time right? > > --Mark > > On 2/28/07, Kevin Dangoor <[EMAIL PROTECTED]> wrote: > > > > Identity (or visit) was doing a database call outside of the view of > > expose. > > > > I think that this can be done in middleware (though Ben was mentioning > > that he didn't like middleware for this because you might not need a > > transaction). > > > > Kevin > > > > On 2/28/07, Mark Ramm <[EMAIL PROTECTED]> wrote: > > > Is there a reason we're opening a transaction in the expose decorator, > > and > > > closing it with a cherrypy filter? > > > > > > I would think we could do both in filters, or both in the expose > > method. > > > > > > We wrote a new cherrypy tool for it, but I'm tempted to put it into > > expose, > > > or to pull the opening of the transaction out of expose and put it > > into a > > > tool. > > > > > > (Alternatively we could create some middleware to do this...) > > > > > > --Mark > > > > > > > > > -- > > Kevin Dangoor > > TurboGears / Zesty News > > > > email: [EMAIL PROTECTED] > > company: http://www.BlazingThings.com > > blog: http://www.BlueSkyOnMars.com > > > > > > -- > Mark Ramm-Christensen > email: mark at compoundthinking dot com > blog: www.compoundthinking.com/blog > -- Mark Ramm-Christensen email: mark at compoundthinking dot com blog: www.compoundthinking.com/blog --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/turbogears-trunk?hl=en -~----------~----~----~----~------~----~------~--~---
