Jorge Godoy schrieb: >> Christoph Zwerschke schrieb: >>> A while ago I already suggested running "reindent" on the whole >>> source tree on a regular basis, to solve the problems with >>> - mixed crlf+lf >>> - mixed tab/space >>> - trailing whitespace >>> >>> These things not only create bloated diffs, >>> but can even cause errors. See: >>> >>> http://effbot.org/pyfaq/how-do-i-keep-editors-from-inserting-tabs-into-my-python-source.htm >>> >>> Does anything speak against this? > On Monday 23 July 2007 20:49:45 Christopher Arndt wrote: >> We could run reindent.py over all .py files in the whole source tree, >> the only drawback is that revision numbers for files changed in that >> process would not reflect a real change to the file. I could live with >> that. Revision number in SVN are fairly arbitrary anyway. > > I did that once... There was so much change that I wasn't up to the task of > reviewing indentation and other things to see if something was wrong...
(taking this discussion to the trunk ml) I just ran tabnanny on the 1.0 and 1.1 branch and found two files with mixed tabs and spaces: turbogears/identity/__init__.py turbogears/toolbox/catwalk/__init__.py I fixed those in SVN for both branches. Then I ran reindent.py on my current (rev 3364) checkout of the 1.0 branch: python /home/chris/tmp/reindent.py -drv . | tee reindent.log grep ' changed.' reindent.log | wc -l 288 Now for real: python /home/chris/tmp/reindent.py -rv . svn stat | grep '^M' | wc -l 288 svn diff | grep '^+' | wc -l 966 Most (all?) of the changed files are those that have either no newline at the end of the file or trailing spaces at the end of lines. All test still run successfully. I also tested further by creating a quickstarted app and starting it and testing the toolbox in the following configurations: - SO w/out identity - SO w/ identity - SA w/out identity - SA w/ identity - Elixir w/out identity - Elixir w/ identity These all worked except the last (but this seems to be an unrelated error, which I will discuss elsewhere) Should I commit? Chris --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/turbogears-trunk?hl=en -~----------~----~----~----~------~----~------~--~---
