On Wed, Nov 4, 2009 at 3:43 PM, Christopher Arndt <[email protected]>wrote:
>
> Ken Kuhlman wrote:
> > Does anyone see the problem behind the failing 1.5 test? In
> test_identity,
> > it's test_json.
> >
> > So far it's eluding me..
>
> These are the lines of the test where it is failing:
>
> response = self.app.get('/json', status=403)
> # we get the output of the identity_failure controller in this case
> assert 'identity_failed_answer' in response, response
> response = self.app.get('/json?tg_format=json', status=403)
> # we get the right status code, but not the output of
> identity_failure
> assert 'identity_failed_answer' not in response, response.body
>
> The second to last assert fails, because the response is
> 'identity_failed_answer', which means the method set for idenity failure
> URL was called (IdentityRoot.identity_failed). The test seems to imply
> that this should not happen, when using 'tg_format=json' in the URL and
> the config setting 'tg.allow_json=False' is set (as done in the
> testcase's setUp method). I'm not sure what correct behavior is in this
> case, maybe Chris Zwerschke, who wrote this test, can shed some light on
> this?
>
> Chris
>
Thanks for the response, Chris.
I'm still going in circles on this, but they're getting tighter. If they
don't reach an end-point in the next 48 hours or so, I'll open a new ticket
for the regression (referencing #2036 & #1985), and tag that line with a
FIXME so that it's out of the way.
I'm getting to the point where it's tempting to dust off Florent's wsgi
version of identity & bypass the nested decorators & generics in
controllers.py. But that might just be the frustration talking; time will
tell.
-Ken
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/turbogears-trunk?hl=en
-~----------~----~----~----~------~----~------~--~---
