On Wed, Jun 29, 2011 at 6:16 AM, Carlos Daniel Ruvalcaba Valenzuela < [email protected]> wrote:
> Following the suggestion by Michael Pedersen, I forked the development > branch to add some jinja2 focused changes, if anyone want to check it > out or fork/pull my stuff: > > https://github.com/clsdaniel/tg2-jinja2-updates > git://github.com/clsdaniel/tg2-jinja2-updates.git > > I'm just starting with the patches, but if there is comments or > feature requests (related to jinja2 support) drop me a mail or and > issue on github. > > So far I just added support for loading extensions and simple filters > along with test cases (which also pass), I'll be adding more as I have > time (or need), I try to follow upstream repository on sourceforge > too. > Great work Carlos, I took a look at the patch and it seems fine, the only thing that I would like to point is that being it a patch that adds a feature it really requires documentation. I think that the two new options for jinja should be added to http://www.turbogears.org/2.1/docs/main/Templates/Jinja.html and I would like to avoid merging in patches that do not have relative documentation if they introduce new features or behavioral changes. We already have doc problems without having to introduce new missing pieces ;) If you can provide the doc for the two new configuration options for me it's a +1 for merge-in Posting discussion to tg-trunk as it is more related to development. -- You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/turbogears-trunk?hl=en.
