Well I was just looking at it and it looks pretty good. I couldn't find
anywhere to improve it.
The only tiny thing I noticed is that the " from {{package}} import model"
line could be used only once as it's the same for both options, but that's
nicpicking
http://sourceforge.net/p/turbogears2/tg2devtools/ci/1c62ad678c5dbfff6be2f2f0d286738f2da67bb2/tree/devtools/templates/turbogears/+package+/controllers/root.py_tmpl?diff=a55f6371a6c097c4c9b21f2c46720c08cd2991c4
On Tue, Aug 9, 2011 at 11:42 PM, Michael Pedersen <[email protected]>wrote:
> I've not reviewed the code, so this is a qualified "I love it". This was
> something that I was going to be looking to work for sometime soon. I'm glad
> you got to it. After we've got 2.1.2 out the door, I'll take the time to do
> a proper review.
>
>
> On Tue, Aug 9, 2011 at 7:19 PM, Alessandro Molina <
> [email protected]> wrote:
>
>> This is something that I always wanted to do but as it was quite long
>> is something that I always postponed.
>> Yesterday I decided that even starting with something not really
>> perfect would have been an improvement over nothing and so I started
>> writing the necessary code.
>>
>> To support this I created the ming branch on both tg.devtools and
>> tg.core repositories.
>> Currently I have pushed a version that seems to work with support for
>> authentication, users and groups.
>> Also predicates seem to work correctly for them.
>>
>> What do you guys think?
>> Any review and help is really appreciated as the code is still in
>> "experimental" status and needs some clean up.
>> Also it is still missing ensure_index and permissions support.
>>
>> Involved changes are:
>> devtools ->
>> https://sourceforge.net/p/turbogears2/tg2devtools/ci/1c62ad678c5dbfff6be2f2f0d286738f2da67bb2/
>> core ->
>> https://sourceforge.net/p/turbogears2/tg2/ci/203b2496ab1d413bfcea60aba2f941e910455998/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "TurboGears Trunk" group.
>> To post to this group, send email to [email protected].
>> To unsubscribe from this group, send email to
>> [email protected].
>> For more options, visit this group at
>> http://groups.google.com/group/turbogears-trunk?hl=en.
>>
>>
>
>
> --
> Michael J. Pedersen
> My IM IDs: Jabber/[email protected], AIM/pedermj022171
> Yahoo/pedermj2002, MSN/[email protected]
> My LinkedIn Profile: http://www.linkedin.com/in/michaeljpedersen
> Twitter: pedersentg
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears Trunk" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected].
> For more options, visit this group at
> http://groups.google.com/group/turbogears-trunk?hl=en.
>
--
You received this message because you are subscribed to the Google Groups
"TurboGears Trunk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/turbogears-trunk?hl=en.
