On 23 Oct, 2005, at 4:47 pm, Robert Leftwich wrote:

Can I suggest that you change the model to use a PackageHub instead of an AutoConnectHub to allow the identity data to be sourced from a different db if required?

Excellent idea. I need to look at PackageHub a little closer, but it seems like the right thing to do.

Also, in an attempt to minimise support questions in the future :-), it might be worth adding support for query strings to the login() function of the controller described in the How-To i.e. something like:

    def login( self, *args, **kw ):
        if hasattr(cherrypy.request,"identity_exception"):
            msg= str(cherrypy.request.identity_exception)
        else:
            msg= "Please log in"
        cherrypy.response.status=403
        prevURL = cherrypy.request.path
if cherrypy.request.queryString is not None and len (cherrypy.request.queryString) > 0: prevURL = '%s?%s' % (prevURL, cherrypy.request.queryString)
        return dict( message=msg, previous_url=prevURL )

Actually, I want to provide a default login function (currently I raise an Exception when you haven't defined a failure_url) which will generate either a POST or a GET with the identity parameters *PLUS* the exact same parameters as the original request. This would mean your app wouldn't know the difference when an authentication event happens.

Jeff

--
Jeff Watkins
http://metrocat.org/

"Daddy, I want a purple iMac. And I want ice cream!"
-- Unidentified 7-year-old to his father.


Reply via email to