David Bernard wrote: > Hi, Hi,
> > I want to port the CRUD package of my TG app to 0.9 svn, and may be, > submit it to Turbogear. > But to do this I need to understand some choice... > > 1) in TableForm : Why using cherrypy.request.form_errors instead of a > dict inserted into input_values with key "error"? Regarding this, wouldn't be nice to make all these thing (has_errors, form_errors, input_values) easily accessible using some methods provided by the Form widget itself? > 2) in TableForm : Why define form_javascript() and form_css() instead > of > def _get_javascript(self): > # copy code of form_javascript > javascript = property(_get_javascript) > > def _get_css(self): > # copy code of form_javascript > css = property(_get_css) > In changeset 256 [1], Kevin committed my patch that changes these methods to be retrieve_css and retrieve_javascript and also moves them to the Widget base class (needed to make widgets work even if they aren't inside a form), anyway I was also thinking that it's probably better to make them properties. Ciao Michele [1] http://trac.turbogears.org/turbogears/changeset/265
