Lee McFadden <[EMAIL PROTECTED]> writes:

> On 1/26/06, Jorge Godoy <[EMAIL PROTECTED]> wrote:
>>
>> I've added some comments to this one.  Specially one change that I'd like to
>> see reverted from your patch.
>>
>
> I've copied this from my comment on the ticket.
>
> I don't see how it would break any implimentation for the different
> CSS classes on the widget. The code I've used there was on the
> original widget and also is on other widgets in base.py.

Take a look at http://trac.turbogears.org/turbogears/ticket/413 and at the
link cited there:
http://groups.google.com/group/turbogears/browse_thread/thread/5ebe0dc0bda1f5df/e3c6783a526f1cb1#e3c6783a526f1cb1

The code I cited on the ticket was removed only from CalendarDatePicker and
was left on all other widgets.

> Can you show me an example of this implimentation in case other
> widgets are also lagging behind and I'm using old code as a reference?

All other have it.  You can take a look at line 45 for Widget, line 56 for its
__init__ method, line 76/77 still in __init__, line 295 for Label, line 305
for TextField, line 313 for PasswordField, line 321 for ButtonField, line 329
for ImageField, line 337 for FileField, line 346 for TextArea, line 362 for
FieldSet, line 435 for SelectField, line 452 for Checkable, line 483 for
CheckableList and at line 595 of base.py for AutoCompleteField.  All these
implement what has been removed from CalendarDatePicker.


I'll copy this to the ticket, to keep it complete.

-- 
Jorge Godoy      <[EMAIL PROTECTED]>

Reply via email to