Ronald Jaramillo wrote:
> Hi Michele,

Hi Ronald,

> Cool, just a nit:
> Could you use and underscore instead of '-' betwen widget.field_id
> and value? I don't like to see "price-2" as a radio option.
> Underscores make it clear (in the HTML/javascript/css) that we are
> talking about strings.
> I told you this was a nit =)

Done in 0.6 (also with an example of using dynamic options).

By the way I would love to hear more of these nits, regarding id and
classes we should try to provide the best defaults IMHO, so if you (or
anyone) have others nits don't esitate to point them out.

For example, in this widgets every field embedded inside a form has and
id of the type form-name_field-id (just to avoid possible ids
collisions, like footer and so on).
So for a form whose name is "page" you get, for example:

id="page_name"

Ciao
Michele

Reply via email to