On 2/2/06, Michele Cella <[EMAIL PROTECTED]> wrote: > > Kevin Dangoor wrote: > > * all of those crazy parameters to create_dict, insert and render have > > been eliminated. Just pass in appropriate keywords for your widgets. > > (the value parameter for the first parameter is still supported, of > > course...) > > > > Regarding this, since we support options at the constructor I think we > should also add options here at display time (and fix the problem with > _collect_options making options a property see #490).
I think "options" should only exist for select fields. Otherwise, a widget should use named parameters for the things that are of interest/value to it. One thing that may be useful to do is allow you to put a list of widget attributes that you'd like to make available to the template and have that do the equivalent of: d[that_attribute] = d.get(that_attribute, getattr(self, that_attribute)) That would make all of these types of things overrideable at display() time. We could, if it's desirable, make that automatically call a callable, but I'm a bit less certain on that one. > > * disabled_fields on forms has become disabled_widgets > > I left it to be disabled_fields AFAIK. :-/ I think I may have actually written that note backwards :( It's disabled_fields. > I noticed they don't work anymore as on my initial implementation (that > Alberto tested), anyway I will left the selection field to you so you > can check things, the CheckBox is now broken also (still using > create_dict and not respecting the default value), I'm cooking a patch > (with a test to show the supposed behavior). Thanks for writing those tests! That was a big help! Always nice to know that more of the functions are tested. > Great work by the way. Thanks, and same to you! Kevin
