Brian Beck wrote:
> The tutorial application is hosted online here:
> http://exogen.case.edu:8001
>
> You can grab the source produced in the tutorial here:
> http://exogen.case.edu/tg_tutorial.tar.gz
>
> Comments and changes welcome.
Hi Brian,
Firstly, I'd like to say that in my opinion this is the best TurboGears
tutorial available so far, probably because it explains almost
everything instead of leaving things implicit, sending you scurrying to
try and find other documentation!
With that said, I've put my editor hat on and here's what I think you
might want consider looking at:
- hub.commit() is left as a little bit of unexplained black magic. You
might want to consider explaining in a sentence or two what the hub is.
I didn't find it incredibly obvious from looking at the other TG docs
so a mention here might be helpful.
- l1 is not a great variable name ;) I can imagine someone somewhere
scratching their head because they typed the wrong thing. Maybe list1
would be better as it's more obvious what it represents. The same
happens later with "for l in user.lists" which may look like "for 1 in
user.lists" in some typefaces and confuse unwary programmers new to
Python.
- I was under the impression that "raise
cherrypy.HTTPRedirect('index')" was superceded by
"turbogears.redirect('index')" from 0.9 onwards, though I am not too
familiar with 0.9 and there may be subtle differences I don't know
about?
- In parts of the tutorial where source is repeated from above, would
it be possible to shade the new lines differently to highlight what is
added at each stage?
That's all - thanks for the hard work!
--
Ben Sizer
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TurboGears" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/turbogears
-~----------~----~----~----~------~----~------~--~---