Alberto Valverde wrote:
> Looks pretty good :)
>
> One thing, class MultiFieldsetTable(TableForm) could be just class
> MultiFieldsetTable(Form) as you're providing a custom template.
> TableForm just provides a template to Form so you can skip one
> inheritance step. Just a picky detail ;)
>
@Alberto:
That's not the case since Ed is also using table_attrs in its template
that's provided by TableForm.
@Ed:
Change this:
params = ["fieldsets"]
fieldsets = []
to be:
member_widgets = ["fieldsets"]
fieldsets = []
this ensures that fieldsets is immutable after construction, that the
validation schema is correctly generated and that javascript and css
for member widgets are retrieved correctly.
As a rule of thumb, you use params for every generic parameter that you
can update at subclassing, construction and display/render, while you
use member_widgets when you're making a CompoundWidget that's made up
of other widgets, in this case your various field sets.
Other than that everything looks ok.
Ciao
Michele
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TurboGears" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/turbogears
-~----------~----~----~----~------~----~------~--~---
