Jorge Vargas wrote: > On 6/2/06, *Peter Russell* <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > hi peter
Hi, Thanks for your quick response > > I'm not sure if I'm posting this in the right place. > > > yes thats the way to get people to notice > > I attached a patch to ticket #629 a couple of weeks ago. It seems > that > no one has looked at it since. I just wanted to ping people, to > see if > there is any chance of getting it fixed. > > > I check it and I don't think fixing the test to match the code is a > good idea. Perhaps not, but it is also important that tests be self contained, so that when a test fails, you can be sure of where the bug is. If running tests in a different order causes them to pass, this is surely a problem with the tests themselves. In this case a test that is autogenerated by TG is causing our (correct) tests to fail. This is surely a significant issue, it certainly seems like one to me, after I spent two days trying to find a non-existent bug in our code! > even more weird is the fact that it gets fix by changing the type of > test method. Yeah, I realise that submitting a patch that appears to fix the problem without understanding why it does so, is probably not good practise. I hoped that it would spur someone into fixing the real issue. My understanding of CherryPy is not very deep as yet. Presumably it's something to do with the lifespan of objects allocated in methods compared to objects allocated in global functions or something. > > Have you tested the old code in newer releases, I think unless a good > explanation of why a class works and a method doesn't that patch will > not be accepted. Can anyone explain this? I've only tested against 0.9a6, the SVN 1.0 branch, and SVN Head. I don't know about other versions. > Thanks, > > Peter Russell > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/turbogears -~----------~----~----~----~------~----~------~--~---
