There are a few areas I'd like to have someone look over.

1. Line 130 is where I made a fix for the handling of submitted form
data.  It is passed via URI, but must first be converted from a dict in
the case of CompoundWidget data.  More info in the docstring.  I just
wonder if there is a better way to do this.

2. The ordering data is stored as a dict and passed in the URI.  Check
how I convert it from string to dict in line 261.  I'm trying to keep
is secure since it is untrusted input.

3. Line 248 - I sure would like to be more explicit when checking for
an SQLObject column.  InstanceType is quite generic.  Any ideas.

I did not make any API changes (that I know of).  I don't think there
are any existing tests for this module, so I can't verify I didn't
break something.  I'll have to write tests from scratch, but I wanted
to get some feedback on it ASAP.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/turbogears
-~----------~----~----~----~------~----~------~--~---

Reply via email to